]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
staging: rtl8192u: Replace explicit NULL comparison
authorGargi Sharma <gs051095@gmail.com>
Thu, 23 Feb 2017 20:16:46 +0000 (01:46 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 6 Mar 2017 08:17:01 +0000 (09:17 +0100)
Replace explicit NULL comparison with ! operator to
simplify code.

Found with Coccinelle script:
@@
expression ptr;
position p;
statement s0, s1;
@@

ptr@p =
\(kmalloc\|devm_kzalloc\|kmalloc_array\|devm_ioremap\|usb_alloc_urb\|
alloc_netdev\|dev_alloc_skb\)(...)
... when != ptr

if (
(
+ !
ptr
- == NULL
)
) s0 else s1

Signed-off-by: Gargi Sharma <gs051095@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c

index 6619b8fb9700aaf6991dcb614b1aa45084397e70..e82b5073c3f1de04db4f4de49a917ec83c0ca857 100644 (file)
@@ -117,7 +117,7 @@ static struct sk_buff *ieee80211_ADDBA(struct ieee80211_device *ieee, u8 *Dst, P
                return NULL;
        }
        skb = dev_alloc_skb(len + sizeof( struct rtl_80211_hdr_3addr)); //need to add something others? FIXME
-       if (skb == NULL) {
+       if (!skb) {
                IEEE80211_DEBUG(IEEE80211_DL_ERR, "can't alloc skb for ADDBA_REQ\n");
                return NULL;
        }
@@ -202,7 +202,7 @@ static struct sk_buff *ieee80211_DELBA(
        DelbaParamSet.field.TID = pBA->BaParamSet.field.TID;
 
        skb = dev_alloc_skb(len + sizeof( struct rtl_80211_hdr_3addr)); //need to add something others? FIXME
-       if (skb == NULL) {
+       if (!skb) {
                IEEE80211_DEBUG(IEEE80211_DL_ERR, "can't alloc skb for ADDBA_REQ\n");
                return NULL;
        }