]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
spi: pic32-sqi: remove unnecessary of_node_get()
authorAlexey Khoroshilov <khoroshilov@ispras.ru>
Fri, 14 Sep 2018 20:05:34 +0000 (23:05 +0300)
committerMark Brown <broonie@kernel.org>
Mon, 17 Sep 2018 17:54:08 +0000 (10:54 -0700)
Almost all spi drivers assign spi master->dev.of_node from
its parent platform device without additional refcounting.
It seems of_node_get() in pic32_sqi_probe() is unnecessary
and there is no corresponding of_node_put().

Found by Linux Driver Verification project (linuxtesting.org)

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-pic32-sqi.c

index bd1c6b53283f60c019e77f217ce7510c24a8e0ce..62e6bf1f50b100fcd4813aa988635ddd42480807 100644 (file)
@@ -656,7 +656,7 @@ static int pic32_sqi_probe(struct platform_device *pdev)
        master->max_speed_hz    = clk_get_rate(sqi->base_clk);
        master->dma_alignment   = 32;
        master->max_dma_len     = PESQI_BD_BUF_LEN_MAX;
-       master->dev.of_node     = of_node_get(pdev->dev.of_node);
+       master->dev.of_node     = pdev->dev.of_node;
        master->mode_bits       = SPI_MODE_3 | SPI_MODE_0 | SPI_TX_DUAL |
                                  SPI_RX_DUAL | SPI_TX_QUAD | SPI_RX_QUAD;
        master->flags           = SPI_MASTER_HALF_DUPLEX;