]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
net: ethernet: don't set phylib state CHANGELINK in drivers
authorHeiner Kallweit <hkallweit1@gmail.com>
Tue, 18 Dec 2018 23:43:58 +0000 (00:43 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 19 Dec 2018 06:07:20 +0000 (22:07 -0800)
After phy_start() phylib takes care of all needed actions, including
aneg settings and checking link state. There's no need to set state
PHY_CHANGELINK in drivers.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/amd/au1000_eth.c
drivers/net/ethernet/ti/cpmac.c

index 7c1eb304c27ec84dc56fb337473c2c867af3669e..e833d1b3fe1806b80c7452d9a5770134478a3f00 100644 (file)
@@ -940,11 +940,8 @@ static int au1000_open(struct net_device *dev)
                return retval;
        }
 
-       if (dev->phydev) {
-               /* cause the PHY state machine to schedule a link state check */
-               dev->phydev->state = PHY_CHANGELINK;
+       if (dev->phydev)
                phy_start(dev->phydev);
-       }
 
        netif_start_queue(dev);
 
index 9b8a30bf939bf946baed5f93228178e5fa686037..810dfc7de1f9125763af49ad0a2c6070901f7313 100644 (file)
@@ -991,7 +991,6 @@ static int cpmac_open(struct net_device *dev)
        cpmac_hw_start(dev);
 
        napi_enable(&priv->napi);
-       dev->phydev->state = PHY_CHANGELINK;
        phy_start(dev->phydev);
 
        return 0;