]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
iommu/arm-smmu: Remove duplicate error message
authorJean-Philippe Brucker <jean-philippe@linaro.org>
Mon, 11 Nov 2019 11:17:21 +0000 (12:17 +0100)
committerJoerg Roedel <jroedel@suse.de>
Mon, 11 Nov 2019 14:44:17 +0000 (15:44 +0100)
Since commit 7723f4c5ecdb ("driver core: platform: Add an error message
to platform_get_irq*()"), platform_get_irq() displays an error when the
IRQ isn't found. Remove the error print from the SMMU driver. Note the
slight change of behaviour: no message is printed if platform_get_irq()
returns -EPROBE_DEFER, which probably doesn't concern the SMMU.

Fixes: 7723f4c5ecdb ("driver core: platform: Add an error message to platform_get_irq*()")
Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
Acked-by: Will Deacon <will@kernel.org>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/arm-smmu.c

index 424ebf38cd09f8d11db8e1a59e8f10f57ca25f6d..f05c821dd181157d85dbdfc472af70748374176e 100644 (file)
@@ -2095,10 +2095,8 @@ static int arm_smmu_device_probe(struct platform_device *pdev)
        for (i = 0; i < num_irqs; ++i) {
                int irq = platform_get_irq(pdev, i);
 
-               if (irq < 0) {
-                       dev_err(dev, "failed to get irq index %d\n", i);
+               if (irq < 0)
                        return -ENODEV;
-               }
                smmu->irqs[i] = irq;
        }