]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
staging: vc04_services: Remove VCHIQ_GET_CONFIG_T typedef
authorDominic Braun <inf.braun@fau.de>
Fri, 14 Dec 2018 12:04:56 +0000 (13:04 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 17 Dec 2018 13:45:12 +0000 (14:45 +0100)
Typedefing structs is not encouraged in the kernel.

Signed-off-by: Dominic Braun <inf.braun@fau.de>
Signed-off-by: Tobias Büttner <tobias.buettner@fau.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h

index 2db679af38e2e1016af48412bbc6ab65a5134fba..14f638f59668be84225f82a380fb1ecc16dfbdce 100644 (file)
@@ -1407,7 +1407,7 @@ vchiq_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
        } break;
 
        case VCHIQ_IOC_GET_CONFIG: {
-               VCHIQ_GET_CONFIG_T args;
+               struct vchiq_get_config args;
                struct vchiq_config config;
 
                if (copy_from_user(&args, (const void __user *)arg,
@@ -1911,7 +1911,7 @@ vchiq_compat_ioctl_get_config(struct file *file,
                              unsigned int cmd,
                              unsigned long arg)
 {
-       VCHIQ_GET_CONFIG_T __user *args;
+       struct vchiq_get_config __user *args;
        struct vchiq_get_config32 args32;
 
        args = compat_alloc_user_space(sizeof(*args));
index f4d8bd2b3c6b9e3ce08a0b042f9581fd4243bfc6..6de2dd3c37d176dc3da12ea5c37ee06771b9123d 100644 (file)
@@ -83,10 +83,10 @@ struct vchiq_dequeue_message {
        void *buf;
 };
 
-typedef struct {
+struct vchiq_get_config {
        unsigned int config_size;
        struct vchiq_config __user *pconfig;
-} VCHIQ_GET_CONFIG_T;
+};
 
 typedef struct {
        unsigned int handle;
@@ -116,7 +116,7 @@ struct vchiq_dump_mem {
        _IOWR(VCHIQ_IOC_MAGIC, 8, struct vchiq_dequeue_message)
 #define VCHIQ_IOC_GET_CLIENT_ID        _IO(VCHIQ_IOC_MAGIC,   9)
 #define VCHIQ_IOC_GET_CONFIG \
-       _IOWR(VCHIQ_IOC_MAGIC, 10, VCHIQ_GET_CONFIG_T)
+       _IOWR(VCHIQ_IOC_MAGIC, 10, struct vchiq_get_config)
 #define VCHIQ_IOC_CLOSE_SERVICE        _IO(VCHIQ_IOC_MAGIC,   11)
 #define VCHIQ_IOC_USE_SERVICE          _IO(VCHIQ_IOC_MAGIC,   12)
 #define VCHIQ_IOC_RELEASE_SERVICE      _IO(VCHIQ_IOC_MAGIC,   13)