]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
ASoC: soc-core: Remove unneeded dentry member from snd_soc_codec
authorFabio Estevam <festevam@gmail.com>
Mon, 7 Aug 2017 12:08:52 +0000 (09:08 -0300)
committerMark Brown <broonie@kernel.org>
Mon, 7 Aug 2017 15:47:21 +0000 (16:47 +0100)
There is no need to have the *debugfs_reg dentry member as part of
the snd_soc_codec structure as its only usage is inside
soc_init_codec_debugfs().

Use a local dentry variable instead.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
include/sound/soc.h
sound/soc/soc-core.c

index 10b71beb9f13f81fb8907fa86b88a93248c19bb7..aad3f14966f13f369a3a84d6549c557829c7589e 100644 (file)
@@ -903,10 +903,6 @@ struct snd_soc_codec {
 
        /* component */
        struct snd_soc_component component;
-
-#ifdef CONFIG_DEBUG_FS
-       struct dentry *debugfs_reg;
-#endif
 };
 
 /* codec driver */
index 921622a019448394687655034f52befb4abfd6ec..558efdfd717df3f0e2a5fed49d9e27bde95e56bb 100644 (file)
@@ -339,11 +339,12 @@ static void soc_cleanup_component_debugfs(struct snd_soc_component *component)
 static void soc_init_codec_debugfs(struct snd_soc_component *component)
 {
        struct snd_soc_codec *codec = snd_soc_component_to_codec(component);
+       struct dentry *debugfs_reg;
 
-       codec->debugfs_reg = debugfs_create_file("codec_reg", 0644,
-                                                codec->component.debugfs_root,
-                                                codec, &codec_reg_fops);
-       if (!codec->debugfs_reg)
+       debugfs_reg = debugfs_create_file("codec_reg", 0644,
+                                         codec->component.debugfs_root,
+                                         codec, &codec_reg_fops);
+       if (!debugfs_reg)
                dev_warn(codec->dev,
                        "ASoC: Failed to create codec register debugfs file\n");
 }