]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
xfs: fix len comparison in xfs_extent_busy_trim
authorArnd Bergmann <arnd@arndb.de>
Wed, 15 Feb 2017 02:16:50 +0000 (18:16 -0800)
committerDarrick J. Wong <darrick.wong@oracle.com>
Fri, 17 Feb 2017 01:20:12 +0000 (17:20 -0800)
The length is now passed by reference, so the assertion has to be updated
to match the other changes, as pointed out by this W=1 warning:

fs/xfs/xfs_extent_busy.c: In function 'xfs_extent_busy_trim':
fs/xfs/xfs_extent_busy.c:356:13: error: ordered comparison of pointer with integer zero [-Werror=extra]

Fixes: ebf55872616c ("xfs: improve handling of busy extents in the low-level allocator")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
fs/xfs/xfs_extent_busy.c

index ab062610234e072e20ee4530a740713733842d83..77760dbf0242ee9b2f191c6fcf6329e3e2389ae8 100644 (file)
@@ -353,7 +353,7 @@ xfs_extent_busy_trim(
        struct rb_node          *rbp;
        bool                    ret = false;
 
-       ASSERT(len > 0);
+       ASSERT(*len > 0);
 
        spin_lock(&args->pag->pagb_lock);
 restart: