]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
Input: omap-keypad - remove dead check
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Thu, 7 Jan 2016 23:06:51 +0000 (15:06 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 8 Jan 2016 01:26:23 +0000 (17:26 -0800)
Commit da1f026b532ce944d74461497dc6d8c16456466e ("Keyboard: omap-keypad:
use matrix_keypad.h") switched the driver to use matrix keypad
infrastructure, which made array of keycodes to be unsigned short, and
caused the test for negativity never trigger. This leads to the following
static checker warning:

drivers/input/keyboard/omap-keypad.c:158 omap_kp_tasklet()
warn: 'keycodes[]' is never negative.

Given that we did not care about this check for a few years already let's
simply remove it.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Aaro Koskinen <aaro.koskinen@nokia.com>
Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/keyboard/omap-keypad.c

index 75ad6661e1308087aedab4073436f3de87b9de05..e0d72c8c01e428290ca56b6263087a4b013a9631 100644 (file)
@@ -155,14 +155,6 @@ static void omap_kp_tasklet(unsigned long data)
                               "pressed" : "released");
 #else
                        key = keycodes[MATRIX_SCAN_CODE(row, col, row_shift)];
-                       if (key < 0) {
-                               printk(KERN_WARNING
-                                     "omap-keypad: Spurious key event %d-%d\n",
-                                      col, row);
-                               /* We scan again after a couple of seconds */
-                               spurious = 1;
-                               continue;
-                       }
 
                        if (!(kp_cur_group == (key & GROUP_MASK) ||
                              kp_cur_group == -1))