]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
coresight: Use PTR_ERR_OR_ZERO()
authorVasyl Gomonovych <gomonovych@gmail.com>
Mon, 18 Dec 2017 18:05:43 +0000 (11:05 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 19 Dec 2017 09:05:18 +0000 (10:05 +0100)
Fix ptr_ret.cocci warnings:
drivers/hwtracing/coresight/coresight-tpiu.c:163:1-3: WARNING: PTR_ERR_OR_ZERO can be used
drivers/hwtracing/coresight/coresight-funnel.c:217:1-3: WARNING: PTR_ERR_OR_ZERO can be used
drivers/hwtracing/coresight/coresight-dynamic-replicator.c:166:1-3: WARNING: PTR_ERR_OR_ZERO can be used

Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hwtracing/coresight/coresight-dynamic-replicator.c
drivers/hwtracing/coresight/coresight-funnel.c
drivers/hwtracing/coresight/coresight-tpiu.c

index 8f4357e2626c5a704214f6aafcfb60cee776b7e5..043da86b0fe93329a472731953ed149ff6c13c28 100644 (file)
@@ -163,10 +163,8 @@ static int replicator_probe(struct amba_device *adev, const struct amba_id *id)
        desc.dev = &adev->dev;
        desc.groups = replicator_groups;
        drvdata->csdev = coresight_register(&desc);
-       if (IS_ERR(drvdata->csdev))
-               return PTR_ERR(drvdata->csdev);
 
-       return 0;
+       return PTR_ERR_OR_ZERO(drvdata->csdev);
 }
 
 #ifdef CONFIG_PM
index fd3c396717f61e74099a76eef2a3c17aaaa1dbad..9f8ac0bef8533ee18f824382b0d5cc2251536153 100644 (file)
@@ -214,10 +214,8 @@ static int funnel_probe(struct amba_device *adev, const struct amba_id *id)
        desc.dev = dev;
        desc.groups = coresight_funnel_groups;
        drvdata->csdev = coresight_register(&desc);
-       if (IS_ERR(drvdata->csdev))
-               return PTR_ERR(drvdata->csdev);
 
-       return 0;
+       return PTR_ERR_OR_ZERO(drvdata->csdev);
 }
 
 #ifdef CONFIG_PM
index bef49a3a5ca7148748cad69e9c6ac9ab1614961e..76ea1b8d4db596ec199c1686667fc13626ada4ab 100644 (file)
@@ -160,10 +160,8 @@ static int tpiu_probe(struct amba_device *adev, const struct amba_id *id)
        desc.pdata = pdata;
        desc.dev = dev;
        drvdata->csdev = coresight_register(&desc);
-       if (IS_ERR(drvdata->csdev))
-               return PTR_ERR(drvdata->csdev);
 
-       return 0;
+       return PTR_ERR_OR_ZERO(drvdata->csdev);
 }
 
 #ifdef CONFIG_PM