]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
MIPS: PCI: remember nasid changed by set interrupt affinity
authorThomas Bogendoerfer <tbogendoerfer@suse.de>
Tue, 19 Nov 2019 11:08:57 +0000 (12:08 +0100)
committerPaul Burton <paulburton@kernel.org>
Fri, 22 Nov 2019 18:56:16 +0000 (10:56 -0800)
When changing interrupt affinity remember the possible changed nasid,
otherwise an interrupt deactivate/activate sequence will incorrectly
setup interrupt.

Fixes: e6308b6d35ea ("MIPS: SGI-IP27: abstract chipset irq from bridge")
Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
Signed-off-by: Paul Burton <paulburton@kernel.org>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: James Hogan <jhogan@kernel.org>
Cc: linux-mips@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
arch/mips/pci/pci-xtalk-bridge.c

index 72e60df505f4133bce1a7ffc3002d49a78ac4a30..05753fad70bfba08464f5f789e8b2e37cbb59751 100644 (file)
@@ -306,16 +306,15 @@ static int bridge_set_affinity(struct irq_data *d, const struct cpumask *mask,
        struct bridge_irq_chip_data *data = d->chip_data;
        int bit = d->parent_data->hwirq;
        int pin = d->hwirq;
-       nasid_t nasid;
        int ret, cpu;
 
        ret = irq_chip_set_affinity_parent(d, mask, force);
        if (ret >= 0) {
                cpu = cpumask_first_and(mask, cpu_online_mask);
-               nasid = cpu_to_node(cpu);
+               data->nasid = cpu_to_node(cpu);
                bridge_write(data->bc, b_int_addr[pin].addr,
                             (((data->bc->intr_addr >> 30) & 0x30000) |
-                             bit | (nasid << 8)));
+                             bit | (data->nasid << 8)));
                bridge_read(data->bc, b_wid_tflush);
        }
        return ret;