]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
KVM: PPC: e500: Use kcalloc() in e500_mmu_host_init()
authorMarkus Elfring <elfring@users.sourceforge.net>
Fri, 20 Jan 2017 15:30:18 +0000 (16:30 +0100)
committerPaul Mackerras <paulus@ozlabs.org>
Thu, 20 Apr 2017 01:37:55 +0000 (11:37 +1000)
* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "kcalloc".

  This issue was detected by using the Coccinelle software.

* Replace the specification of a data type by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Paul Mackerras <paulus@ozlabs.org>
arch/powerpc/kvm/e500_mmu_host.c

index 0fda4230f6c0f878f7cf2e0957ae941d489326fd..77fd043b3ecc50857ac25cc266fd559be715e9de 100644 (file)
@@ -797,9 +797,8 @@ int e500_mmu_host_init(struct kvmppc_vcpu_e500 *vcpu_e500)
        host_tlb_params[0].sets =
                host_tlb_params[0].entries / host_tlb_params[0].ways;
        host_tlb_params[1].sets = 1;
-
-       vcpu_e500->h2g_tlb1_rmap = kzalloc(sizeof(unsigned int) *
-                                          host_tlb_params[1].entries,
+       vcpu_e500->h2g_tlb1_rmap = kcalloc(host_tlb_params[1].entries,
+                                          sizeof(*vcpu_e500->h2g_tlb1_rmap),
                                           GFP_KERNEL);
        if (!vcpu_e500->h2g_tlb1_rmap)
                return -EINVAL;