firmware: arm_scmi: Remove extra check for invalid length message responses

scmi_xfer_get_init ensures both transmit and receive buffer lengths are
within the maximum limits. If receive buffer length is not supplied by
the caller, it's set to the maximum limit value. Receive buffer length
is never modified after that. So there's no need for the extra check
when receive transmit completion for a command essage.

Further, if the response header length is greater than the prescribed
receive buffer length, the response buffer is truncated to the latter.

Reported-by: Jim Quinlan <james.quinlan@broadcom.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>

diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
index b5bc4c7a8fab2957bb0842b95e32d152f11837aa..6ef652940099724487d3e9da355fc4f8cde1d368 100644 (file)
--- a/drivers/firmware/arm_scmi/driver.c
+++ b/drivers/firmware/arm_scmi/driver.c
@@ -230,12 +230,6 @@ static void scmi_rx_callback(struct mbox_client *cl, void *m)
        xfer = &minfo->xfer_block[xfer_id];
 
        scmi_dump_header_dbg(dev, &xfer->hdr);
-       /* Is the message of valid length? */
-       if (xfer->rx.len > info->desc->max_msg_size) {
-               dev_err(dev, "unable to handle %zu xfer(max %d)\n",
-                       xfer->rx.len, info->desc->max_msg_size);
-               return;
-       }
 
        scmi_fetch_response(xfer, mem);
        complete(&xfer->done);