]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
staging: erofs: differentiate unsupported on-disk format
authorGao Xiang <gaoxiang25@huawei.com>
Wed, 14 Aug 2019 10:37:04 +0000 (18:37 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 15 Aug 2019 12:24:30 +0000 (14:24 +0200)
For some specific fields, use EOPNOTSUPP instead of EIO
for values which look sane but aren't supported right now.

Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
Link: https://lore.kernel.org/r/20190814103705.60698-2-gaoxiang25@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/erofs/inode.c
drivers/staging/erofs/zmap.c

index 961c3ab91a8aa9f6b0c412d40e7dabda23e81c4a..cbc2c342a37fcd6b9ae2d29d1808261ebbaf124e 100644 (file)
@@ -24,7 +24,7 @@ static int read_inode(struct inode *inode, void *data)
                errln("unsupported data mapping %u of nid %llu",
                      vi->datamode, vi->nid);
                DBG_BUGON(1);
-               return -EIO;
+               return -EOPNOTSUPP;
        }
 
        if (__inode_version(advise) == EROFS_INODE_LAYOUT_V2) {
@@ -95,7 +95,7 @@ static int read_inode(struct inode *inode, void *data)
                errln("unsupported on-disk inode version %u of nid %llu",
                      __inode_version(advise), vi->nid);
                DBG_BUGON(1);
-               return -EIO;
+               return -EOPNOTSUPP;
        }
 
        if (!nblks)
index 16b3625604f4743358871203dfc40ab0d3cd9029..5551e615e8eaa64d5b1886c7e5acc476ebf26d84 100644 (file)
@@ -178,7 +178,7 @@ static int vle_legacy_load_cluster_from_disk(struct z_erofs_maprecorder *m,
                break;
        default:
                DBG_BUGON(1);
-               return -EIO;
+               return -EOPNOTSUPP;
        }
        m->type = type;
        return 0;
@@ -362,7 +362,7 @@ static int vle_extent_lookback(struct z_erofs_maprecorder *m,
                errln("unknown type %u at lcn %lu of nid %llu",
                      m->type, lcn, vi->nid);
                DBG_BUGON(1);
-               return -EIO;
+               return -EOPNOTSUPP;
        }
        return 0;
 }
@@ -436,7 +436,7 @@ int z_erofs_map_blocks_iter(struct inode *inode,
        default:
                errln("unknown type %u at offset %llu of nid %llu",
                      m.type, ofs, vi->nid);
-               err = -EIO;
+               err = -EOPNOTSUPP;
                goto unmap_out;
        }