]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
can: mcp251x: Use dev_name() during request_threaded_irq()
authorAlexander Shiyan <shc_work@mail.ru>
Thu, 31 Jan 2019 08:46:11 +0000 (11:46 +0300)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Tue, 20 Aug 2019 11:41:26 +0000 (13:41 +0200)
Passing driver name as name during request_threaded_irq() results in all
CAN IRQs have same name. This does not help much to easily identify which
IRQ belongs to which CAN instance. Therefore pass dev_name() during
request_threaded_irq() so that better identifiable name is listed for
CAN devices in cat /proc/interrupts output.

Output of cat /proc/interrupts
Before this patch:
  253:          2  gpio-mxc  13 Edge      mcp251x
  259:          2  gpio-mxc  19 Edge      mcp251x
After this patch:
  253:          2  gpio-mxc  13 Edge      spi1.1
  259:          2  gpio-mxc  19 Edge      spi1.2

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
Tested-by: Sean Nyekjaer <sean@geanix.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/spi/mcp251x.c

index 74cb19a2bd08b5bef9a05cd97b06cc81eb5cff83..407c02f2eb8e1bd997e2082709d679a11754f8e1 100644 (file)
@@ -930,7 +930,8 @@ static int mcp251x_open(struct net_device *net)
        priv->tx_len = 0;
 
        ret = request_threaded_irq(spi->irq, NULL, mcp251x_can_ist,
-                                  flags | IRQF_ONESHOT, DEVICE_NAME, priv);
+                                  flags | IRQF_ONESHOT, dev_name(&spi->dev),
+                                  priv);
        if (ret) {
                dev_err(&spi->dev, "failed to acquire irq %d\n", spi->irq);
                goto out_close;