]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
staging: most: sound: Fix error path of audio_init
authorYueHaibing <yuehaibing@huawei.com>
Tue, 27 Aug 2019 13:13:46 +0000 (21:13 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 28 Aug 2019 20:22:13 +0000 (22:22 +0200)
If most_register_configfs_subsys() fails, we should
call most_deregister_component() do cleanup.

Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 919c03ae11b9 ("staging: most: enable configfs support")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Link: https://lore.kernel.org/r/20190827131346.12704-1-yuehaibing@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/most/sound/sound.c

index 342f390d68b36739b2fa4953223863b9ed596e0f..79817061fcfa41cb85318a6373655a7f796c00e4 100644 (file)
@@ -802,8 +802,11 @@ static int __init audio_init(void)
        if (ret)
                pr_err("Failed to register %s\n", comp.name);
        ret = most_register_configfs_subsys(&comp);
-       if (ret)
+       if (ret) {
                pr_err("Failed to register %s configfs subsys\n", comp.name);
+               most_deregister_component(&comp);
+       }
+
        return ret;
 }