]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
cifs: potential unintitliazed error code in cifs_getattr()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 28 Feb 2020 09:22:59 +0000 (12:22 +0300)
committerSteve French <stfrench@microsoft.com>
Tue, 17 Mar 2020 18:26:26 +0000 (13:26 -0500)
Smatch complains that "rc" could be uninitialized.

    fs/cifs/inode.c:2206 cifs_getattr() error: uninitialized symbol 'rc'.

Changing it to "return 0;" improves readability as well.

Fixes: cc1baf98c8f6 ("cifs: do not ignore the SYNC flags in getattr")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Acked-by: Ronnie Sahlberg <lsahlber@redhat.com>
fs/cifs/inode.c

index 1e8a4b1579db49791592fdba227672f01c97d806..b16f8d23e97b58d51b756a4b35e1995dc195120d 100644 (file)
@@ -2191,7 +2191,7 @@ int cifs_getattr(const struct path *path, struct kstat *stat,
                if (!(cifs_sb->mnt_cifs_flags & CIFS_MOUNT_OVERR_GID))
                        stat->gid = current_fsgid();
        }
-       return rc;
+       return 0;
 }
 
 int cifs_fiemap(struct inode *inode, struct fiemap_extent_info *fei, u64 start,