]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
drm/amdgpu: error out on mode1 reset failure
authorEvan Quan <evan.quan@amd.com>
Fri, 15 Mar 2019 02:02:59 +0000 (10:02 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 28 Mar 2019 03:40:12 +0000 (22:40 -0500)
The error return value should be correctly reflected.

Signed-off-by: Evan Quan <evan.quan@amd.com>
Reviewed-by: Feifei Xu <Feifei.Xu@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/soc15.c

index 77493a0f5e7ed4760349be9fd87a0537304d92d7..bdb5ad93990d4d2e190623dafb19cba5d538bec5 100644 (file)
@@ -393,6 +393,7 @@ void soc15_program_register_sequence(struct amdgpu_device *adev,
 static int soc15_asic_mode1_reset(struct amdgpu_device *adev)
 {
        u32 i;
+       int ret = 0;
 
        amdgpu_atombios_scratch_regs_engine_hung(adev, true);
 
@@ -403,7 +404,9 @@ static int soc15_asic_mode1_reset(struct amdgpu_device *adev)
 
        pci_save_state(adev->pdev);
 
-       psp_gpu_reset(adev);
+       ret = psp_gpu_reset(adev);
+       if (ret)
+               dev_err(adev->dev, "GPU mode1 reset failed\n");
 
        pci_restore_state(adev->pdev);
 
@@ -418,7 +421,7 @@ static int soc15_asic_mode1_reset(struct amdgpu_device *adev)
 
        amdgpu_atombios_scratch_regs_engine_hung(adev, false);
 
-       return 0;
+       return ret;
 }
 
 static int soc15_asic_get_baco_capability(struct amdgpu_device *adev, bool *cap)