staging: gasket: remove gasket_sysfs_register_show()

In an attempt to start to clean up the monstrosity of the sysfs abuse in
the gasket driver, let's remove code that is not used at all.  The
gasket_sysfs_register_show() function is never used, so delete it.

Cc: Rob Springer <rspringer@google.com>
Cc: John Joseph <jnjoseph@google.com>
Cc: Ben Chan <benchan@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/gasket/gasket_sysfs.c b/drivers/staging/gasket/gasket_sysfs.c
index 94e55f19b43f588e8d3a87b4efb59b0cab019de8..39f9595c85e8afc6204c9a63d8e7adfb23daa39f 100644 (file)
--- a/drivers/staging/gasket/gasket_sysfs.c
+++ b/drivers/staging/gasket/gasket_sysfs.c
@@ -396,44 +396,6 @@ void gasket_sysfs_put_attr(
 }
 EXPORT_SYMBOL(gasket_sysfs_put_attr);
 
-ssize_t gasket_sysfs_register_show(
-       struct device *device, struct device_attribute *attr, char *buf)
-{
-       ulong reg_address, reg_bar, reg_value;
-       struct gasket_sysfs_mapping *mapping;
-       struct gasket_dev *gasket_dev;
-       struct gasket_sysfs_attribute *gasket_attr;
-
-       mapping = get_mapping(device);
-       if (!mapping) {
-               gasket_nodev_info("Device driver may have been removed.");
-               return 0;
-       }
-
-       gasket_dev = mapping->gasket_dev;
-       if (!gasket_dev) {
-               gasket_nodev_error(
-                       "No sysfs mapping found for device 0x%p", device);
-               put_mapping(mapping);
-               return 0;
-       }
-
-       gasket_attr = gasket_sysfs_get_attr(device, attr);
-       if (!gasket_attr) {
-               put_mapping(mapping);
-               return 0;
-       }
-
-       reg_address = gasket_attr->data.bar_address.offset;
-       reg_bar = gasket_attr->data.bar_address.bar;
-       reg_value = gasket_dev_read_64(gasket_dev, reg_bar, reg_address);
-
-       gasket_sysfs_put_attr(device, gasket_attr);
-       put_mapping(mapping);
-       return snprintf(buf, PAGE_SIZE, "0x%lX\n", reg_value);
-}
-EXPORT_SYMBOL(gasket_sysfs_register_show);
-
 ssize_t gasket_sysfs_register_store(
        struct device *device, struct device_attribute *attr, const char *buf,
        size_t count)

diff --git a/drivers/staging/gasket/gasket_sysfs.h b/drivers/staging/gasket/gasket_sysfs.h
index 0949cdae876c5bc04c3bb9634695b6c03b35d6e2..e9f4fad804612c14712f8825562b3e79dcdddea7 100644 (file)
--- a/drivers/staging/gasket/gasket_sysfs.h
+++ b/drivers/staging/gasket/gasket_sysfs.h
@@ -167,10 +167,6 @@ struct gasket_sysfs_attribute *gasket_sysfs_get_attr(
 void gasket_sysfs_put_attr(
        struct device *device, struct gasket_sysfs_attribute *attr);
 
-/* Display a register as a sysfs node. */
-ssize_t gasket_sysfs_register_show(
-       struct device *device, struct device_attribute *attr, char *buf);
-
 /*
  * Write to a register sysfs node.
  * @buf: NULL-terminated data being written.