]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
lan78xx: remove redundant initialization of pointer 'phydev'
authorColin Ian King <colin.king@canonical.com>
Thu, 1 Feb 2018 17:10:18 +0000 (17:10 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 1 Feb 2018 19:54:28 +0000 (14:54 -0500)
Pointer phydev is initialized and this value is never read, phydev
is immediately updated to a new value, hence this initialization
is redundant and can be removed

Cleans up clang warning:
drivers/net/usb/lan78xx.c:2009:21: warning: Value stored to 'phydev'
during its initialization is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/lan78xx.c

index ec56ff29aac4ed9f28e3f984093968da53147ac5..60a604cc7647e460539d0482c69f9ffc8f882aa1 100644 (file)
@@ -2006,7 +2006,7 @@ static int lan78xx_phy_init(struct lan78xx_net *dev)
 {
        int ret;
        u32 mii_adv;
-       struct phy_device *phydev = dev->net->phydev;
+       struct phy_device *phydev;
 
        phydev = phy_find_first(dev->mdiobus);
        if (!phydev) {