]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
dma-buf/sw-sync: sync_pt is private and of fixed size
authorChris Wilson <chris@chris-wilson.co.uk>
Thu, 29 Jun 2017 12:59:28 +0000 (13:59 +0100)
committerGustavo Padovan <gustavo.padovan@collabora.com>
Thu, 29 Jun 2017 21:52:34 +0000 (18:52 -0300)
Since sync_pt is only allocated from a single location and is no longer
the base class for fences (that is struct dma_fence) it no longer needs
a generic unsized allocator.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Sean Paul <seanpaul@chromium.org>
Cc: Gustavo Padovan <gustavo@padovan.org>
Reviewed-by: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170629125930.821-5-chris@chris-wilson.co.uk
drivers/dma-buf/sw_sync.c

index fc733621987d40fec176d4be3cfac0f55acc627f..6effa1ce010e8f2ea591c3e29de7c8d2b0090334 100644 (file)
@@ -155,7 +155,6 @@ static void sync_timeline_signal(struct sync_timeline *obj, unsigned int inc)
 /**
  * sync_pt_create() - creates a sync pt
  * @parent:    fence's parent sync_timeline
- * @size:      size to allocate for this pt
  * @inc:       value of the fence
  *
  * Creates a new sync_pt as a child of @parent.  @size bytes will be
@@ -163,15 +162,12 @@ static void sync_timeline_signal(struct sync_timeline *obj, unsigned int inc)
  * the generic sync_timeline struct. Returns the sync_pt object or
  * NULL in case of error.
  */
-static struct sync_pt *sync_pt_create(struct sync_timeline *obj, int size,
-                            unsigned int value)
+static struct sync_pt *sync_pt_create(struct sync_timeline *obj,
+                                     unsigned int value)
 {
        struct sync_pt *pt;
 
-       if (size < sizeof(*pt))
-               return NULL;
-
-       pt = kzalloc(size, GFP_KERNEL);
+       pt = kzalloc(sizeof(*pt), GFP_KERNEL);
        if (!pt)
                return NULL;
 
@@ -312,7 +308,7 @@ static long sw_sync_ioctl_create_fence(struct sync_timeline *obj,
                goto err;
        }
 
-       pt = sync_pt_create(obj, sizeof(*pt), data.value);
+       pt = sync_pt_create(obj, data.value);
        if (!pt) {
                err = -ENOMEM;
                goto err;