]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
net: phy: don't change modes we don't care about in genphy_c45_read_lpa
authorHeiner Kallweit <hkallweit1@gmail.com>
Fri, 22 Feb 2019 22:50:49 +0000 (23:50 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sat, 23 Feb 2019 22:12:09 +0000 (14:12 -0800)
Because 1000BaseT isn't covered by Clause 45, the 1000BaseT flags in
phydev->lp_advertising may have been set based on vendor registers
already. genphy_c45_read_lpa() would clear these flags as of today.
Therefore switch to mii_lpa_mod_linkmode_lpa_t.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/phy-c45.c

index fc3173cc078bfe5444c6d071a7d39a9da95d3004..2d1ba43e14ec97bc9e818eaf298f965c9ddaac20 100644 (file)
@@ -275,7 +275,7 @@ int genphy_c45_read_lpa(struct phy_device *phydev)
        if (val < 0)
                return val;
 
-       mii_lpa_to_linkmode_lpa_t(phydev->lp_advertising, val);
+       mii_lpa_mod_linkmode_lpa_t(phydev->lp_advertising, val);
        phydev->pause = val & LPA_PAUSE_CAP ? 1 : 0;
        phydev->asym_pause = val & LPA_PAUSE_ASYM ? 1 : 0;