]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
drm/vmwgfx: Remove bogus crtc coords vs fb size check
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 1 Nov 2017 18:29:16 +0000 (20:29 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Mon, 20 Nov 2017 17:52:30 +0000 (19:52 +0200)
Throw away the bugs crtc coords vs. fb size check. Crtc coords don't
define the viewport inside the fb, that's a job for the src coords,
which have been checked by the core already.

Cc: VMware Graphics <linux-graphics-maintainer@vmware.com>
Cc: Sinclair Yeh <syeh@vmware.com>
Cc: Thomas Hellstrom <thellstrom@vmware.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20171101182920.14386-2-ville.syrjala@linux.intel.com
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Sinclair Yeh <syeh@vmware.com>
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c

index b850562fbdd657f489632dceb467597f4a63b84c..4f127a3f99e4b0b15aafd45528d862e356337a60 100644 (file)
@@ -476,12 +476,6 @@ int vmw_du_primary_plane_atomic_check(struct drm_plane *plane,
 
                vcs = vmw_connector_state_to_vcs(du->connector.state);
 
-               if ((dest.x2 > new_fb->width ||
-                    dest.y2 > new_fb->height)) {
-                       DRM_ERROR("CRTC area outside of framebuffer\n");
-                       return -EINVAL;
-               }
-
                /* Only one active implicit framebuffer at a time. */
                mutex_lock(&dev_priv->global_kms_state_mutex);
                if (vcs->is_implicit && dev_priv->implicit_fb &&