]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
cpufreq: powernv: add of_node_put()
authorYangtao Li <tiny.windzz@gmail.com>
Tue, 20 Nov 2018 16:05:30 +0000 (11:05 -0500)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 29 Nov 2018 21:33:32 +0000 (22:33 +0100)
The of_find_node_by_path() returns a node pointer with refcount
incremented,but there is the lack of use of the of_node_put() when
done.Add the missing of_node_put() to release the refcount.

Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/cpufreq/powernv-cpufreq.c

index bf6519cf64bc2e040b6e004f1771e47e5691c7e0..7e7ad3879c4e0510ee1de789815fec26ad807040 100644 (file)
@@ -253,18 +253,18 @@ static int init_powernv_pstates(void)
 
        if (of_property_read_u32(power_mgt, "ibm,pstate-min", &pstate_min)) {
                pr_warn("ibm,pstate-min node not found\n");
-               return -ENODEV;
+               goto out;
        }
 
        if (of_property_read_u32(power_mgt, "ibm,pstate-max", &pstate_max)) {
                pr_warn("ibm,pstate-max node not found\n");
-               return -ENODEV;
+               goto out;
        }
 
        if (of_property_read_u32(power_mgt, "ibm,pstate-nominal",
                                 &pstate_nominal)) {
                pr_warn("ibm,pstate-nominal not found\n");
-               return -ENODEV;
+               goto out;
        }
 
        if (of_property_read_u32(power_mgt, "ibm,pstate-ultra-turbo",
@@ -293,14 +293,14 @@ static int init_powernv_pstates(void)
        pstate_ids = of_get_property(power_mgt, "ibm,pstate-ids", &len_ids);
        if (!pstate_ids) {
                pr_warn("ibm,pstate-ids not found\n");
-               return -ENODEV;
+               goto out;
        }
 
        pstate_freqs = of_get_property(power_mgt, "ibm,pstate-frequencies-mhz",
                                      &len_freqs);
        if (!pstate_freqs) {
                pr_warn("ibm,pstate-frequencies-mhz not found\n");
-               return -ENODEV;
+               goto out;
        }
 
        if (len_ids != len_freqs) {
@@ -311,7 +311,7 @@ static int init_powernv_pstates(void)
        nr_pstates = min(len_ids, len_freqs) / sizeof(u32);
        if (!nr_pstates) {
                pr_warn("No PStates found\n");
-               return -ENODEV;
+               goto out;
        }
 
        powernv_pstate_info.nr_pstates = nr_pstates;
@@ -352,7 +352,12 @@ static int init_powernv_pstates(void)
 
        /* End of list marker entry */
        powernv_freqs[i].frequency = CPUFREQ_TABLE_END;
+
+       of_node_put(power_mgt);
        return 0;
+out:
+       of_node_put(power_mgt);
+       return -ENODEV;
 }
 
 /* Returns the CPU frequency corresponding to the pstate_id. */