]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
ALSA: sparc: Clean up with new procfs helpers
authorTakashi Iwai <tiwai@suse.de>
Mon, 4 Feb 2019 15:06:43 +0000 (16:06 +0100)
committerTakashi Iwai <tiwai@suse.de>
Wed, 6 Feb 2019 17:11:57 +0000 (18:11 +0100)
Simplify the proc fs creation code with new helper functions,
snd_card_ro_proc_new() and snd_card_rw_proc_new().
Just a code refactoring and no functional changes.

Reviewed-by: Jaroslav Kysela <perex@perex.cz>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/sparc/dbri.c

index 7609eceba1a2dc3b5adf1e145c8743be1327b918..682166202098df0646e9ce41cbd2dea4c5d67692 100644 (file)
@@ -2510,16 +2510,10 @@ static void dbri_debug_read(struct snd_info_entry *entry,
 static void snd_dbri_proc(struct snd_card *card)
 {
        struct snd_dbri *dbri = card->private_data;
-       struct snd_info_entry *entry;
-
-       if (!snd_card_proc_new(card, "regs", &entry))
-               snd_info_set_text_ops(entry, dbri, dbri_regs_read);
 
+       snd_card_ro_proc_new(card, "regs", dbri, dbri_regs_read);
 #ifdef DBRI_DEBUG
-       if (!snd_card_proc_new(card, "debug", &entry)) {
-               snd_info_set_text_ops(entry, dbri, dbri_debug_read);
-               entry->mode = S_IFREG | 0444;   /* Readable only. */
-       }
+       snd_card_ro_proc_new(card, "debug", dbri, dbri_debug_read);
 #endif
 }