]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
perf trace: Show error message when not finding a field used in a filter expression
authorArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 17 Oct 2019 19:41:34 +0000 (16:41 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 17 Oct 2019 20:26:35 +0000 (17:26 -0300)
It was there, but as pr_debug(), make it pr_err() so that we can see it
without -v:

  # trace -e syscalls:*lseek --filter="whenc==SET" sleep 1
  "whenc" not found in "syscalls:sys_enter_lseek", can't set filter "whenc==SET"
  #

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Luis Cláudio Gonçalves <lclaudio@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: https://lkml.kernel.org/n/tip-ly4rgm1bto8uwc2itpaixjob@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-trace.c

index e71605c99080d10ba42762aeb726824184d90ccd..cafd18466dfa0aee29176fba3afd28338424ee3a 100644 (file)
@@ -3611,8 +3611,8 @@ static int trace__expand_filter(struct trace *trace __maybe_unused, struct evsel
 
                        fmt = perf_evsel__syscall_arg_fmt(evsel, arg);
                        if (fmt == NULL) {
-                               pr_debug("\"%s\" not found in \"%s\", can't set filter \"%s\"\n",
-                                        arg, evsel->name, evsel->filter);
+                               pr_err("\"%s\" not found in \"%s\", can't set filter \"%s\"\n",
+                                      arg, evsel->name, evsel->filter);
                                return -1;
                        }