]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
isdn: hisax: Fix pnp_irq's error checking for setup_elsa_isapnp
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Thu, 16 Nov 2017 04:27:21 +0000 (09:57 +0530)
committerDavid S. Miller <davem@davemloft.net>
Thu, 16 Nov 2017 13:31:15 +0000 (22:31 +0900)
The pnp_irq() function returns -1 if an error occurs.
pnp_irq() error checking for zero is not correct.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/isdn/hisax/elsa.c

index b21c05820f4496cd6ea84f18733fae0567c519ec..0754c074379056ceeaa5cd07efb9e39dc81d1f6e 100644 (file)
@@ -945,7 +945,7 @@ static int setup_elsa_isapnp(struct IsdnCard *card)
                                        card->para[1] = pnp_port_start(pnp_d, 0);
                                        card->para[0] = pnp_irq(pnp_d, 0);
 
-                                       if (!card->para[0] || !card->para[1]) {
+                                       if (card->para[0] == -1 || !card->para[1]) {
                                                printk(KERN_ERR "Elsa PnP:some resources are missing %ld/%lx\n",
                                                       card->para[0], card->para[1]);
                                                pnp_disable_dev(pnp_d);