]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
ALSA: xen-front: remove redundant error check on ret
authorColin Ian King <colin.king@canonical.com>
Sun, 27 May 2018 21:23:12 +0000 (22:23 +0100)
committerTakashi Iwai <tiwai@suse.de>
Mon, 28 May 2018 09:28:44 +0000 (11:28 +0200)
The error for a -ve value in ret is redundant as all previous
assignments to ret have an associated -ve check and hence it
is impossible for ret to be less that zero at the point of the
check.  Remove this redundant error check.

Detected by CoveritScan, CID#1469407 ("Logically Dead code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/xen/xen_snd_front_evtchnl.c

index d70a62e7f91085913443fdab100fb76c1b7a3957..102d6e096cc845cf7ab5a2cd4ef5488eb07a120f 100644 (file)
@@ -351,8 +351,6 @@ int xen_snd_front_evtchnl_create_all(struct xen_snd_front_info *front_info,
                        }
                }
        }
-       if (ret < 0)
-               goto fail;
 
        front_info->num_evt_pairs = num_streams;
        return 0;