]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
clk: axi-clkgen: Remove sometimes impossible check
authorStephen Boyd <sboyd@codeaurora.org>
Sat, 30 Jan 2016 01:09:01 +0000 (17:09 -0800)
committerStephen Boyd <sboyd@codeaurora.org>
Sat, 30 Jan 2016 01:11:02 +0000 (17:11 -0800)
The size of unsigned long on 64-bit architectures is equal to the
size of u64, so this check is impossible there. This throws off
static checkers:

drivers/clk/clk-axi-clkgen.c:331 axi_clkgen_recalc_rate() warn:
impossible condition '(tmp > (~0)) => (0-u64max > u64max)'

Let's change this code to use min_t() instead so that we
get the same effect on architectures where sizeof(unsigned long)
doesn't equal sizeof(u64).

Cc: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
drivers/clk/clk-axi-clkgen.c

index 9a0744c9947c5fc3dc439f679b5c85e88b9b3c86..3294db3b4e4e7303903b7a0b10a149b25642b148 100644 (file)
@@ -328,10 +328,7 @@ static unsigned long axi_clkgen_recalc_rate(struct clk_hw *clk_hw,
        tmp = (unsigned long long)(parent_rate / d) * m;
        do_div(tmp, dout);
 
-       if (tmp > ULONG_MAX)
-               return ULONG_MAX;
-
-       return tmp;
+       return min_t(unsigned long long, tmp, ULONG_MAX);
 }
 
 static int axi_clkgen_enable(struct clk_hw *clk_hw)