gpiolib: acpi: Print pin number on acpi_gpiochip_alloc_event errors

Print pin number and error-code on acpi_gpiochip_alloc_event errors,
to help debugging these.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20191114102600.34558-1-hdegoede@redhat.com
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
index 609ed16ae9333bd25f154e3f4f399d6cfeda5234..7b02ee2de0a0662c3d5f01d607aa5d9632504cc9 100644 (file)
--- a/drivers/gpio/gpiolib-acpi.c
+++ b/drivers/gpio/gpiolib-acpi.c
@@ -230,19 +230,25 @@ static acpi_status acpi_gpiochip_alloc_event(struct acpi_resource *ares,
        desc = gpiochip_request_own_desc(chip, pin, "ACPI:Event",
                                         GPIO_ACTIVE_HIGH, GPIOD_IN);
        if (IS_ERR(desc)) {
-               dev_err(chip->parent, "Failed to request GPIO\n");
+               dev_err(chip->parent,
+                       "Failed to request GPIO for pin 0x%04X, err %ld\n",
+                       pin, PTR_ERR(desc));
                return AE_ERROR;
        }
 
        ret = gpiochip_lock_as_irq(chip, pin);
        if (ret) {
-               dev_err(chip->parent, "Failed to lock GPIO as interrupt\n");
+               dev_err(chip->parent,
+                       "Failed to lock GPIO pin 0x%04X as interrupt, err %d\n",
+                       pin, ret);
                goto fail_free_desc;
        }
 
        irq = gpiod_to_irq(desc);
        if (irq < 0) {
-               dev_err(chip->parent, "Failed to translate GPIO to IRQ\n");
+               dev_err(chip->parent,
+                       "Failed to translate GPIO pin 0x%04X to IRQ, err %d\n",
+                       pin, irq);
                goto fail_unlock_irq;
        }