]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
pinctrl: qcom: sdm845: Fix CONFIG preprocessor guard
authorNathan Chancellor <natechancellor@gmail.com>
Fri, 21 Jun 2019 20:20:43 +0000 (13:20 -0700)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 25 Jun 2019 14:06:23 +0000 (16:06 +0200)
Clang warns when CONFIG_ACPI is unset:

 drivers/pinctrl/qcom/pinctrl-sdm845.c:1320:5: warning: 'CONFIG_ACPI' is
 not defined, evaluates to 0 [-Wundef]
 #if CONFIG_ACPI
     ^
 1 warning generated.

Use ifdef instead of if to resolve this.

Fixes: a229105d7a1e ("pinctrl: qcom: sdm845: Provide ACPI support")
Link: https://github.com/ClangBuiltLinux/linux/issues/569
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Acked-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/qcom/pinctrl-sdm845.c

index 06790e5ece6ca9d4c85f9860af0dd8e4dcd5735b..39f498c099063df9877835dd879ac6c52991a46f 100644 (file)
@@ -1317,7 +1317,7 @@ static int sdm845_pinctrl_probe(struct platform_device *pdev)
        return ret;
 }
 
-#if CONFIG_ACPI
+#ifdef CONFIG_ACPI
 static const struct acpi_device_id sdm845_pinctrl_acpi_match[] = {
        { "QCOM0217"},
        { },