]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
gpio-exar/8250-exar: Rearrange gpiochip parenthood
authorJan Kiszka <jan.kiszka@siemens.com>
Sun, 21 May 2017 09:49:24 +0000 (11:49 +0200)
committerJan Kiszka <jan.kiszka@siemens.com>
Mon, 3 Jul 2017 06:30:51 +0000 (08:30 +0200)
Set the parent of the exar gpiochip to its platform device, like other
gpiochips are doing it. In order to keep the relationship discoverable
for ACPI systems, set the platform device companion to the PCI device.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-exar.c
drivers/tty/serial/8250/8250_exar.c

index f3585a184f392d1a25f193ee43e81dec748ee7b6..1a629831d45bd5487123503af47968e7677c0513 100644 (file)
@@ -142,7 +142,7 @@ static int gpio_exar_probe(struct platform_device *pdev)
 
        sprintf(exar_gpio->name, "exar_gpio%d", index);
        exar_gpio->gpio_chip.label = exar_gpio->name;
-       exar_gpio->gpio_chip.parent = &pcidev->dev;
+       exar_gpio->gpio_chip.parent = &pdev->dev;
        exar_gpio->gpio_chip.direction_output = exar_direction_output;
        exar_gpio->gpio_chip.direction_input = exar_direction_input;
        exar_gpio->gpio_chip.get_direction = exar_get_direction;
index 36877c8ad6522a82d3a2aa0ffb6bd46ddb11bcfe..32e3cb58193f5cb42b1a88cfd9789e18ae3f68c0 100644 (file)
@@ -9,6 +9,7 @@
  * it under the terms of the GNU General Public License as published by
  * the Free Software Foundation; either version 2 of the License.
  */
+#include <linux/acpi.h>
 #include <linux/io.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
@@ -197,6 +198,7 @@ xr17v35x_register_gpio(struct pci_dev *pcidev)
                return NULL;
 
        pdev->dev.parent = &pcidev->dev;
+       ACPI_COMPANION_SET(&pdev->dev, ACPI_COMPANION(&pcidev->dev));
 
        if (platform_device_add(pdev) < 0) {
                platform_device_put(pdev);