]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
tipc: reduce sensitive to retransmit failures
authorHoang Le <hoang.h.le@dektech.com.au>
Wed, 6 Nov 2019 06:26:10 +0000 (13:26 +0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 7 Nov 2019 01:37:43 +0000 (17:37 -0800)
With huge cluster (e.g >200nodes), the amount of that flow:
gap -> retransmit packet -> acked will take time in case of STATE_MSG
dropped/delayed because a lot of traffic. This lead to 1.5 sec tolerance
value criteria made link easy failure around 2nd, 3rd of failed
retransmission attempts.

Instead of re-introduced criteria of 99 faled retransmissions to fix the
issue, we increase failure detection timer to ten times tolerance value.

Fixes: 77cf8edbc0e7 ("tipc: simplify stale link failure criteria")
Acked-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: Hoang Le <hoang.h.le@dektech.com.au>
Acked-by: Jon
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tipc/link.c

index 038861bad72be43635545159da9fa6d609d425a2..2aed7a958a8c0897a13b8c2336242071b2e18586 100644 (file)
@@ -1087,7 +1087,7 @@ static bool link_retransmit_failure(struct tipc_link *l, struct tipc_link *r,
                return false;
 
        if (!time_after(jiffies, TIPC_SKB_CB(skb)->retr_stamp +
-                       msecs_to_jiffies(r->tolerance)))
+                       msecs_to_jiffies(r->tolerance * 10)))
                return false;
 
        hdr = buf_msg(skb);