iwlwifi: mvm: warn on invalid statistics size

Getting the wrong statistics size is a problem, having a warning
will help us catch it quicker during firmware/driver development.
In released firmware/driver versions, we obviously make sure this
won't happen.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rx.c b/drivers/net/wireless/intel/iwlwifi/mvm/rx.c
index 184c749766f29455bc57bf71ecb84b905a6354a7..185a1d8414b96066678e7a12d0004c258694b478 100644 (file)
--- a/drivers/net/wireless/intel/iwlwifi/mvm/rx.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/rx.c
@@ -661,11 +661,10 @@ void iwl_mvm_handle_rx_statistics(struct iwl_mvm *mvm,
                expected_size = sizeof(struct iwl_notif_statistics_cdb);
        }
 
-       if (iwl_rx_packet_payload_len(pkt) != expected_size) {
-               IWL_ERR(mvm, "received invalid statistics size (%d)!\n",
-                       iwl_rx_packet_payload_len(pkt));
+       if (WARN_ONCE(iwl_rx_packet_payload_len(pkt) != expected_size,
+                     "received invalid statistics size (%d)!\n",
+                     iwl_rx_packet_payload_len(pkt)))
                return;
-       }
 
        if (!iwl_mvm_has_new_rx_stats_api(mvm)) {
                struct iwl_notif_statistics_v11 *stats = (void *)&pkt->data;