net sched actions: avoid bitwise operation on signed value in pedit

Since char can be unsigned or signed, and bitwise operators may have
implementation-dependent results when performed on signed operands,
declare 'u8 *' operand instead.

Suggested-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: Roman Mashak <mrv@mojatatu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/sched/act_pedit.c b/net/sched/act_pedit.c
index caa6927a992c19fcb4c7cae2c6eec0aac7c1f5c4..ab151346d3d45a754046f239642e1fa6b3e16808 100644 (file)
--- a/net/sched/act_pedit.c
+++ b/net/sched/act_pedit.c
@@ -311,7 +311,7 @@ static int tcf_pedit(struct sk_buff *skb, const struct tc_action *a,
                        }
 
                        if (tkey->offmask) {
-                               char *d, _d;
+                               u8 *d, _d;
 
                                if (!offset_valid(skb, hoffset + tkey->at)) {
                                        pr_info("tc action pedit 'at' offset %d out of bounds\n",