]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
net: hns3: remove the Redundant put_vector in hns3_client_uninit
authorPeng Li <lipeng321@huawei.com>
Thu, 28 Jun 2018 04:12:27 +0000 (12:12 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 29 Jun 2018 02:06:34 +0000 (11:06 +0900)
The interface h->ae_algo->ops->put_vector is called in both
hns3_nic_dealloc_vector_data and hns3_nic_uninit_vector_data in
hns3_client_uninit, this will cause vector freed twice.
This patch remove the Redundant put_vector to make vector freed
only once.

Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c

index 1a68952339c2a8207620a05995f8ab5b99e3fc33..beca364910259476579bc2c8c4e14034b6c0f778 100644 (file)
@@ -2745,10 +2745,6 @@ static int hns3_nic_uninit_vector_data(struct hns3_nic_priv *priv)
                if (ret)
                        return ret;
 
-               ret = h->ae_algo->ops->put_vector(h, tqp_vector->vector_irq);
-               if (ret)
-                       return ret;
-
                hns3_free_vector_ring_chain(tqp_vector, &vector_ring_chain);
 
                if (priv->tqp_vector[i].irq_init_flag == HNS3_VECTOR_INITED) {