]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
net: gemini: fix memory leak
authorIgor Pylypiv <igor.pylypiv@gmail.com>
Mon, 19 Mar 2018 06:40:51 +0000 (23:40 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 20 Mar 2018 16:08:45 +0000 (12:08 -0400)
cppcheck report:
[drivers/net/ethernet/cortina/gemini.c:543]: (error) Memory leak: skb_tab

Signed-off-by: Igor Pylypiv <igor.pylypiv@gmail.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/cortina/gemini.c

index 5eb999af2c40004fc028ecd67901c492916480c5..bd3f6e4d134138424ec5d627e6ce1937a7529079 100644 (file)
@@ -540,6 +540,7 @@ static int gmac_setup_txqs(struct net_device *netdev)
 
        if (port->txq_dma_base & ~DMA_Q_BASE_MASK) {
                dev_warn(geth->dev, "TX queue base it not aligned\n");
+               kfree(skb_tab);
                return -ENOMEM;
        }