]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
ext4: release bs.bh before re-using in ext4_xattr_block_find()
authorVasily Averin <vvs@virtuozzo.com>
Wed, 7 Nov 2018 16:07:01 +0000 (11:07 -0500)
committerTheodore Ts'o <tytso@mit.edu>
Wed, 7 Nov 2018 16:07:01 +0000 (11:07 -0500)
bs.bh was taken in previous ext4_xattr_block_find() call,
it should be released before re-using

Fixes: 7e01c8e5420b ("ext3/4: fix uninitialized bs in ...")
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org # 2.6.26
fs/ext4/xattr.c

index 07c3a115f7ae9afc7de3338d0d27922c7c53ccff..07b9a335c8eb4476ad5f5aae40a825621a17abc4 100644 (file)
@@ -2395,6 +2395,8 @@ ext4_xattr_set_handle(handle_t *handle, struct inode *inode, int name_index,
                        error = ext4_xattr_block_set(handle, inode, &i, &bs);
                } else if (error == -ENOSPC) {
                        if (EXT4_I(inode)->i_file_acl && !bs.s.base) {
+                               brelse(bs.bh);
+                               bs.bh = NULL;
                                error = ext4_xattr_block_find(inode, &i, &bs);
                                if (error)
                                        goto cleanup;