]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
IB/rxe: check for allocation failure on elem
authorColin Ian King <colin.king@canonical.com>
Fri, 8 Sep 2017 14:37:45 +0000 (15:37 +0100)
committerDoug Ledford <dledford@redhat.com>
Mon, 9 Oct 2017 13:03:16 +0000 (09:03 -0400)
The allocation for elem may fail (especially because we're using
GFP_ATOMIC) so best to check for a null return.  This fixes a potential
null pointer dereference when assigning elem->pool.

Detected by CoverityScan CID#1357507 ("Dereference null return value")

Fixes: 8700e3e7c485 ("Soft RoCE driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/infiniband/sw/rxe/rxe_pool.c

index c1b5f38f31a58f48ad94aab049c8635c2bca55cb..3b4916680018a7c273d3b03f5a116cd4ffb4c9d8 100644 (file)
@@ -404,6 +404,8 @@ void *rxe_alloc(struct rxe_pool *pool)
        elem = kmem_cache_zalloc(pool_cache(pool),
                                 (pool->flags & RXE_POOL_ATOMIC) ?
                                 GFP_ATOMIC : GFP_KERNEL);
+       if (!elem)
+               return NULL;
 
        elem->pool = pool;
        kref_init(&elem->ref_cnt);