]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
tracing: probeevent: Do not accumulate on ret variable
authorMasami Hiramatsu <mhiramat@kernel.org>
Tue, 7 May 2019 13:55:52 +0000 (22:55 +0900)
committerSteven Rostedt (VMware) <rostedt@goodmis.org>
Wed, 8 May 2019 16:15:11 +0000 (12:15 -0400)
Do not accumulate strlen result on "ret" local variable, because
it is accumulated on "total" local variable for array case.

Link: http://lkml.kernel.org/r/155723735237.9149.3192150444705457531.stgit@devnote2
Fixes: 40b53b771806 ("tracing: probeevent: Add array type support")
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
kernel/trace/trace_probe_tmpl.h

index 4737bb8c07a3851c30fa565d48e3b4dae5da2e8b..c30c61f12dddff4b1e791751c2029a34bd182b93 100644 (file)
@@ -88,7 +88,7 @@ process_fetch_insn_bottom(struct fetch_insn *code, unsigned long val,
        /* 3rd stage: store value to buffer */
        if (unlikely(!dest)) {
                if (code->op == FETCH_OP_ST_STRING) {
-                       ret += fetch_store_strlen(val + code->offset);
+                       ret = fetch_store_strlen(val + code->offset);
                        code++;
                        goto array;
                } else