NFSD: Fix bad using of return value from qword_get

Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>

diff --git a/fs/nfsd/nfs4idmap.c b/fs/nfsd/nfs4idmap.c
index a0ab0a847d6933c2f9e8c90a95465749e65abe93..dc948f667650f51419fbafdafe8383353b10fb66 100644 (file)
--- a/fs/nfsd/nfs4idmap.c
+++ b/fs/nfsd/nfs4idmap.c
@@ -368,7 +368,7 @@ nametoid_parse(struct cache_detail *cd, char *buf, int buflen)
 {
        struct ent ent, *res;
        char *buf1;
-       int error = -EINVAL;
+       int len, error = -EINVAL;
 
        if (buf[buflen - 1] != '\n')
                return (-EINVAL);
@@ -392,8 +392,8 @@ nametoid_parse(struct cache_detail *cd, char *buf, int buflen)
                IDMAP_TYPE_USER : IDMAP_TYPE_GROUP;
 
        /* Name */
-       error = qword_get(&buf, buf1, PAGE_SIZE);
-       if (error <= 0 || error >= IDMAP_NAMESZ)
+       len = qword_get(&buf, buf1, PAGE_SIZE);
+       if (len <= 0 || len >= IDMAP_NAMESZ)
                goto out;
        memcpy(ent.name, buf1, sizeof(ent.name));