]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
DRM: ARC: PGU: cleanup supported format list code
authorEugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Tue, 19 Nov 2019 14:41:45 +0000 (17:41 +0300)
committerAlexey Brodkin <abrodkin@synopsys.com>
Mon, 16 Dec 2019 10:53:05 +0000 (13:53 +0300)
Get rid of 'simplefb_format' structure usage as we only use its
'fourcc' field.

Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
drivers/gpu/drm/arc/arcpgu_crtc.c

index 31d9824c46cc1495964c7bd3ff40058a29ae4db9..5473b19a52eec9a77a69ce8b7c40aa26b6316155 100644 (file)
@@ -20,9 +20,9 @@
 
 #define ENCODE_PGU_XY(x, y)    ((((x) - 1) << 16) | ((y) - 1))
 
-static struct simplefb_format supported_formats[] = {
-       { "r5g6b5", 16, {11, 5}, {5, 6}, {0, 5}, {0, 0}, DRM_FORMAT_RGB565 },
-       { "r8g8b8", 24, {16, 8}, {8, 8}, {0, 8}, {0, 0}, DRM_FORMAT_RGB888 },
+static const u32 arc_pgu_supported_formats[] = {
+       DRM_FORMAT_RGB565,
+       DRM_FORMAT_RGB888,
 };
 
 static void arc_pgu_set_pxl_fmt(struct drm_crtc *crtc)
@@ -30,20 +30,20 @@ static void arc_pgu_set_pxl_fmt(struct drm_crtc *crtc)
        struct arcpgu_drm_private *arcpgu = crtc_to_arcpgu_priv(crtc);
        const struct drm_framebuffer *fb = crtc->primary->state->fb;
        uint32_t pixel_format = fb->format->format;
-       struct simplefb_format *format = NULL;
+       u32 format = DRM_FORMAT_INVALID;
        int i;
        u32 reg_ctrl;
 
-       for (i = 0; i < ARRAY_SIZE(supported_formats); i++) {
-               if (supported_formats[i].fourcc == pixel_format)
-                       format = &supported_formats[i];
+       for (i = 0; i < ARRAY_SIZE(arc_pgu_supported_formats); i++) {
+               if (arc_pgu_supported_formats[i] == pixel_format)
+                       format = arc_pgu_supported_formats[i];
        }
 
-       if (WARN_ON(!format))
+       if (WARN_ON(format == DRM_FORMAT_INVALID))
                return;
 
        reg_ctrl = arc_pgu_read(arcpgu, ARCPGU_REG_CTRL);
-       if (format->fourcc == DRM_FORMAT_RGB565)
+       if (format == DRM_FORMAT_RGB565)
                reg_ctrl &= ~ARCPGU_MODE_RGB888_MASK;
        else
                reg_ctrl |= ARCPGU_MODE_RGB888_MASK;
@@ -195,18 +195,15 @@ static struct drm_plane *arc_pgu_plane_init(struct drm_device *drm)
 {
        struct arcpgu_drm_private *arcpgu = drm->dev_private;
        struct drm_plane *plane = NULL;
-       u32 formats[ARRAY_SIZE(supported_formats)], i;
        int ret;
 
        plane = devm_kzalloc(drm->dev, sizeof(*plane), GFP_KERNEL);
        if (!plane)
                return ERR_PTR(-ENOMEM);
 
-       for (i = 0; i < ARRAY_SIZE(supported_formats); i++)
-               formats[i] = supported_formats[i].fourcc;
-
        ret = drm_universal_plane_init(drm, plane, 0xff, &arc_pgu_plane_funcs,
-                                      formats, ARRAY_SIZE(formats),
+                                      arc_pgu_supported_formats,
+                                      ARRAY_SIZE(arc_pgu_supported_formats),
                                       NULL,
                                       DRM_PLANE_TYPE_PRIMARY, NULL);
        if (ret)