]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
drm/i915/guc: Reduce verbosity on log overflows
authorChris Wilson <chris@chris-wilson.co.uk>
Mon, 17 Jun 2019 10:09:17 +0000 (11:09 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Tue, 18 Jun 2019 10:35:19 +0000 (11:35 +0100)
If the user is clearing the log buffer too slowly, we overflow. As this
is an expected condition, and the driver tries to handle it, reduce the
error message down to a notice.

Michal mentioned that another cause would be incorrect reset handling,
so we don't want to lose the notification entirely.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110817
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190617100917.13110-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/intel_guc_log.c

index bf1446629703ea9ee8b43766c8122ef348c9f3d0..e3b83ecb90b5a8bf47cf57773deedfcb5706dc51 100644 (file)
@@ -208,7 +208,9 @@ static bool guc_check_log_buf_overflow(struct intel_guc_log *log,
                        /* buffer_full_cnt is a 4 bit counter */
                        log->stats[type].sampled_overflow += 16;
                }
-               DRM_ERROR_RATELIMITED("GuC log buffer overflow\n");
+
+               dev_notice_ratelimited(guc_to_i915(log_to_guc(log))->drm.dev,
+                                      "GuC log buffer overflow\n");
        }
 
        return overflow;