]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
kbuild: use $(basename ...) for cmd_asn1_compiler
authorMasahiro Yamada <yamada.masahiro@socionext.com>
Sat, 20 Jul 2019 16:27:38 +0000 (01:27 +0900)
committerMasahiro Yamada <yamada.masahiro@socionext.com>
Tue, 13 Aug 2019 16:10:42 +0000 (01:10 +0900)
$(basename ...) trims the last suffix. Using it is more intuitive in
my opinion.

This pattern rule makes %.asn1.c and %.asn1.h at the same time.
Previously, the short log showed only either of them, depending on
the target file in question.

To clarify that two files are being generated by the single recipe,
I changed the log as follows:

Before:

  ASN.1   crypto/asymmetric_keys/x509.asn1.c

After:

  ASN.1   crypto/asymmetric_keys/x509.asn1.[ch]

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
scripts/Makefile.build

index 2f66ed388d1c33962126c015530147b2f677cef8..edf84ede803cf02bf9c45bca6d6dd5943b5834a2 100644 (file)
@@ -395,9 +395,9 @@ $(obj)/%.lds: $(src)/%.lds.S FORCE
 
 # ASN.1 grammar
 # ---------------------------------------------------------------------------
-quiet_cmd_asn1_compiler = ASN.1   $@
+quiet_cmd_asn1_compiler = ASN.1   $(basename $@).[ch]
       cmd_asn1_compiler = $(objtree)/scripts/asn1_compiler $< \
-                               $(subst .h,.c,$@) $(subst .c,.h,$@)
+                               $(basename $@).c $(basename $@).h
 
 $(obj)/%.asn1.c $(obj)/%.asn1.h: $(src)/%.asn1 $(objtree)/scripts/asn1_compiler
        $(call cmd,asn1_compiler)