ixgbe: Assume provided MAC filter has been verified by macvlan

The macvlan driver itself will validate the MAC address that is configured
for a given interface. There is no need for us to verify it again.

Instead we should be checking to verify that we actually allocate the filter
and have not run out of resources to configure a MAC rule in our filter
table.

Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index e47e0c470508b0f7f10d36880e8de366bd297c9a..9416531335f75b852a27688a4dd52570860e5b52 100644 (file)
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -5406,12 +5406,16 @@ static int ixgbe_fwd_ring_up(struct net_device *vdev,
        if (err)
                goto fwd_queue_err;
 
-       if (is_valid_ether_addr(vdev->dev_addr))
-               ixgbe_add_mac_filter(adapter, vdev->dev_addr,
-                                    VMDQ_P(accel->pool));
+       /* ixgbe_add_mac_filter will return an index if it succeeds, so we
+        * need to only treat it as an error value if it is negative.
+        */
+       err = ixgbe_add_mac_filter(adapter, vdev->dev_addr,
+                                  VMDQ_P(accel->pool));
+       if (err < 0)
+               goto fwd_queue_err;
 
        ixgbe_macvlan_set_rx_mode(vdev, VMDQ_P(accel->pool), adapter);
-       return err;
+       return 0;
 fwd_queue_err:
        ixgbe_fwd_ring_down(vdev, accel);
        return err;