]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
media: venus: remove invalid compat_ioctl32 handler
authorArnd Bergmann <arnd@arndb.de>
Wed, 6 Nov 2019 09:06:54 +0000 (10:06 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Sat, 9 Nov 2019 08:08:30 +0000 (09:08 +0100)
v4l2_compat_ioctl32() is the function that calls into
v4l2_file_operations->compat_ioctl32(), so setting that back to the same
function leads to a trivial endless loop, followed by a kernel
stack overrun.

Remove the incorrect assignment.

Cc: stable@vger.kernel.org
Fixes: 7472c1c69138 ("[media] media: venus: vdec: add video decoder files")
Fixes: aaaa93eda64b ("[media] media: venus: venc: add video encoder files")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/platform/qcom/venus/vdec.c
drivers/media/platform/qcom/venus/venc.c

index 3bd6d5030598e85f8263c7c4aabef904d1f2ab52..8feaf5daece921d78a1ef882965463b92eebc103 100644 (file)
@@ -1416,9 +1416,6 @@ static const struct v4l2_file_operations vdec_fops = {
        .unlocked_ioctl = video_ioctl2,
        .poll = v4l2_m2m_fop_poll,
        .mmap = v4l2_m2m_fop_mmap,
-#ifdef CONFIG_COMPAT
-       .compat_ioctl32 = v4l2_compat_ioctl32,
-#endif
 };
 
 static int vdec_probe(struct platform_device *pdev)
index 501fb8ca55fb115e2c89975ea29a7f7f25a97be9..453edf966d4fc051d53bb8996814c7f990f0f2cd 100644 (file)
@@ -1239,9 +1239,6 @@ static const struct v4l2_file_operations venc_fops = {
        .unlocked_ioctl = video_ioctl2,
        .poll = v4l2_m2m_fop_poll,
        .mmap = v4l2_m2m_fop_mmap,
-#ifdef CONFIG_COMPAT
-       .compat_ioctl32 = v4l2_compat_ioctl32,
-#endif
 };
 
 static int venc_probe(struct platform_device *pdev)