]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
virtio_console: initialize vtermno value for ports
authorPankaj Gupta <pagupta@redhat.com>
Tue, 19 Mar 2019 06:04:06 +0000 (11:34 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 27 Mar 2019 16:28:24 +0000 (01:28 +0900)
For regular serial ports we do not initialize value of vtermno
variable. A garbage value is assigned for non console ports.
The value can be observed as a random integer with [1].

[1] vim /sys/kernel/debug/virtio-ports/vport*p*

This patch initialize the value of vtermno for console serial
ports to '1' and regular serial ports are initiaized to '0'.

Reported-by: siliu@redhat.com
Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/char/virtio_console.c

index fbeb71953526a94ee56f0279f806a51e56296085..05dbfdb9f4afffe6f940858940080e5ba772231d 100644 (file)
@@ -75,7 +75,7 @@ struct ports_driver_data {
        /* All the console devices handled by this driver */
        struct list_head consoles;
 };
-static struct ports_driver_data pdrvdata;
+static struct ports_driver_data pdrvdata = { .next_vtermno = 1};
 
 static DEFINE_SPINLOCK(pdrvdata_lock);
 static DECLARE_COMPLETION(early_console_added);
@@ -1394,6 +1394,7 @@ static int add_port(struct ports_device *portdev, u32 id)
        port->async_queue = NULL;
 
        port->cons.ws.ws_row = port->cons.ws.ws_col = 0;
+       port->cons.vtermno = 0;
 
        port->host_connected = port->guest_connected = false;
        port->stats = (struct port_stats) { 0 };