]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
stacktrace: Get rid of unneeded '!!' pattern
authorJiri Slaby <jslaby@suse.cz>
Mon, 11 Nov 2019 09:26:47 +0000 (10:26 +0100)
committerIngo Molnar <mingo@kernel.org>
Mon, 11 Nov 2019 09:30:59 +0000 (10:30 +0100)
My commit b0c51f158455 ("stacktrace: Don't skip first entry on
noncurrent tasks") adds one or zero to skipnr by "!!(current == tsk)".

But the C99 standard says:

  The == (equal to) and != (not equal to) operators are
  ...
  Each of the operators yields 1 if the specified relation is true and 0
  if it is false.

So there is no need to prepend the above expression by "!!" -- remove it.

Reported-by: Joe Perches <joe@perches.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/20191111092647.27419-1-jslaby@suse.cz
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/stacktrace.c

index c9ea7eb2cb1a321e0896a9f49398c273968da52d..2af66e449aa6a818e7573311e8b821cd597952be 100644 (file)
@@ -142,7 +142,7 @@ unsigned int stack_trace_save_tsk(struct task_struct *tsk, unsigned long *store,
                .store  = store,
                .size   = size,
                /* skip this function if they are tracing us */
-               .skip   = skipnr + !!(current == tsk),
+               .skip   = skipnr + (current == tsk),
        };
 
        if (!try_get_task_stack(tsk))
@@ -300,7 +300,7 @@ unsigned int stack_trace_save_tsk(struct task_struct *task,
                .entries        = store,
                .max_entries    = size,
                /* skip this function if they are tracing us */
-               .skip   = skipnr + !!(current == task),
+               .skip   = skipnr + (current == task),
        };
 
        save_stack_trace_tsk(task, &trace);