]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
drm/amdgpu: use dev_dbg instead of dev_err in the VA IOCTL
authorChristian König <christian.koenig@amd.com>
Mon, 13 Nov 2017 12:58:17 +0000 (13:58 +0100)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 6 Dec 2017 17:48:05 +0000 (12:48 -0500)
Userspace buggy userspace can spam the logs.

Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c

index 59c9facf9bd717cff1c41800d5a64b54e10f10eb..eb75eb44efc681d8dc10789db64de687e963546a 100644 (file)
@@ -558,7 +558,7 @@ int amdgpu_gem_va_ioctl(struct drm_device *dev, void *data,
        int r = 0;
 
        if (args->va_address < AMDGPU_VA_RESERVED_SIZE) {
-               dev_err(&dev->pdev->dev,
+               dev_dbg(&dev->pdev->dev,
                        "va_address 0x%LX is in reserved area 0x%LX\n",
                        args->va_address, AMDGPU_VA_RESERVED_SIZE);
                return -EINVAL;
@@ -576,7 +576,7 @@ int amdgpu_gem_va_ioctl(struct drm_device *dev, void *data,
        args->va_address &= AMDGPU_VA_HOLE_MASK;
 
        if ((args->flags & ~valid_flags) && (args->flags & ~prt_flags)) {
-               dev_err(&dev->pdev->dev, "invalid flags combination 0x%08X\n",
+               dev_dbg(&dev->pdev->dev, "invalid flags combination 0x%08X\n",
                        args->flags);
                return -EINVAL;
        }
@@ -588,7 +588,7 @@ int amdgpu_gem_va_ioctl(struct drm_device *dev, void *data,
        case AMDGPU_VA_OP_REPLACE:
                break;
        default:
-               dev_err(&dev->pdev->dev, "unsupported operation %d\n",
+               dev_dbg(&dev->pdev->dev, "unsupported operation %d\n",
                        args->operation);
                return -EINVAL;
        }