]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
modpost: Get proper section index by get_secindex() instead of st_shndx
authorXiao Yang <yangx.jy@cn.fujitsu.com>
Wed, 18 Mar 2020 10:34:16 +0000 (18:34 +0800)
committerMasahiro Yamada <masahiroy@kernel.org>
Wed, 18 Mar 2020 16:44:25 +0000 (01:44 +0900)
(uint16_t) st_shndx is limited to 65535(i.e. SHN_XINDEX) so sym_get_data() gets
wrong section index by st_shndx if requested symbol contains extended section
index that is more than 65535.  In this case, we need to get proper section index
by .symtab_shndx section.

Module.symvers generated by building kernel with "-ffunction-sections -fdata-sections"
shows the issue.

Fixes: 56067812d5b0 ("kbuild: modversions: add infrastructure for emitting relative CRCs")
Fixes: e84f9fbbece1 ("modpost: refactor namespace_from_kstrtabns() to not hard-code section name")
Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
scripts/mod/modpost.c

index 6ab235354f36b9c3b2cb5a4623ab04d970ef7fea..55a0a2eccbd2bce1948009dfa51c40344fd1f22c 100644 (file)
@@ -308,7 +308,8 @@ static const char *sec_name(struct elf_info *elf, int secindex)
 
 static void *sym_get_data(const struct elf_info *info, const Elf_Sym *sym)
 {
-       Elf_Shdr *sechdr = &info->sechdrs[sym->st_shndx];
+       unsigned int secindex = get_secindex(info, sym);
+       Elf_Shdr *sechdr = &info->sechdrs[secindex];
        unsigned long offset;
 
        offset = sym->st_value;