]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
i2c: acpi: permit bus speed to be discovered after enumeration
authorArd Biesheuvel <ard.biesheuvel@linaro.org>
Fri, 24 May 2019 16:26:46 +0000 (18:26 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Thu, 30 May 2019 07:35:45 +0000 (15:35 +0800)
Currently, the I2C ACPI enumeration code only permits the max bus rate
to be discovered before enumerating the slaves on the bus. In some
cases, drivers for slave devices may require this information, e.g.,
some ATmel crypto drivers need to generate a so-called wake token
of a fixed duration, regardless of the bus rate.

So tweak the code so i2c_acpi_lookup_speed() is able to obtain this
information after enumeration as well.

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/i2c/i2c-core-acpi.c

index 272800692088820cfdafdcb626d8f6f4cb4716ce..7240cc07abb40e91d5a3fa7d79c68e3e7c084256 100644 (file)
@@ -115,8 +115,7 @@ static int i2c_acpi_do_lookup(struct acpi_device *adev,
        struct list_head resource_list;
        int ret;
 
-       if (acpi_bus_get_status(adev) || !adev->status.present ||
-           acpi_device_enumerated(adev))
+       if (acpi_bus_get_status(adev) || !adev->status.present)
                return -EINVAL;
 
        if (acpi_match_device_ids(adev, i2c_acpi_ignored_device_ids) == 0)
@@ -151,6 +150,9 @@ static int i2c_acpi_get_info(struct acpi_device *adev,
        lookup.info = info;
        lookup.index = -1;
 
+       if (acpi_device_enumerated(adev))
+               return -EINVAL;
+
        ret = i2c_acpi_do_lookup(adev, &lookup);
        if (ret)
                return ret;